Discussion:
[LSR] multi-measure-rest-length-control.ly snippet should not use \compressFullBarRests
Federico Bruni
2018-08-30 09:54:25 UTC
Permalink
Hi folks

Bug Squad, this does not require a new issue in the tracker, but just
someone who can fix the snippet on the LSR website.

There's a recent snippet file imported from LSR which contains
\compressFullBarRests.

$ git grep \compressFullBarRests Documentation/snippets
Documentation/snippets/multi-measure-rest-length-control.ly:25:
\compressFullBarRests
Documentation/snippets/new/multi-measure-rest-length-control.ly:17:
\compressFullBarRests


Given this commit:

commit ba9a8dc730bb3a681455150bc0a3eef0976523af
Author: Trevor Daniels <***@treda.co.uk>
Date: Fri May 1 22:56:47 2015 +0100

Issue 3687 (part 2): Amend docs to use \compressMMRests

Amend the examples in the LM and NR to use the \compressMMRests
music function rather than the predefs \compressFullBarRests and
\expandFullBarRests to avoid advocating the use of techniques
which may have undesirable side effects.


we should replace it with \compressMMRests.
Who can do this change in the LSR?

Thanks
Federico

PS Frescobaldi auto-completion is currently suggesting only
\compressFullBarRests.
I've opened a new issue in the python-ly package:
https://github.com/wbsoft/python-ly/issues/130
James Lowe
2018-09-11 12:59:26 UTC
Permalink
Federico
Post by Federico Bruni
Hi folks
Bug Squad, this does not require a new issue in the tracker, but just
someone who can fix the snippet on the LSR website.
There's a recent snippet file imported from LSR which contains
\compressFullBarRests.
$ git grep \compressFullBarRests Documentation/snippets
\compressFullBarRests
\compressFullBarRests
commit ba9a8dc730bb3a681455150bc0a3eef0976523af
Date: Fri May 1 22:56:47 2015 +0100
   Issue 3687 (part 2): Amend docs to use \compressMMRests
     Amend the examples in the LM and NR to use the \compressMMRests
     music function rather than the predefs \compressFullBarRests and
     \expandFullBarRests to avoid advocating the use of techniques
     which may have undesirable side effects.
we should replace it with \compressMMRests.
Who can do this change in the LSR?
I cannot find this on the LSR.

It is in LilyPond's own Snippets (but that is not the same thing) so a
change to this would require a change in git.

Also

grep -r "compressFullBarRests" * | wc -l

gives a count of 38 (of which 14 are *.po files) so we might as well
change it for those files too right?

In which case a tracker would be best.

Let me know.

James
Federico Bruni
2018-09-17 09:10:56 UTC
Permalink
Post by Federico Bruni
Federico
Post by Federico Bruni
Hi folks
Bug Squad, this does not require a new issue in the tracker, but
just someone who can fix the snippet on the LSR website.
There's a recent snippet file imported from LSR which contains
\compressFullBarRests.
$ git grep \compressFullBarRests Documentation/snippets
\compressFullBarRests
\compressFullBarRests
commit ba9a8dc730bb3a681455150bc0a3eef0976523af
Date: Fri May 1 22:56:47 2015 +0100
Issue 3687 (part 2): Amend docs to use \compressMMRests
Amend the examples in the LM and NR to use the \compressMMRests
music function rather than the predefs \compressFullBarRests and
\expandFullBarRests to avoid advocating the use of techniques
which may have undesirable side effects.
we should replace it with \compressMMRests.
Who can do this change in the LSR?
I cannot find this on the LSR.
It is in LilyPond's own Snippets (but that is not the same thing) so
a change to this would require a change in git.
You are right. As it's a command introduced in a development version,
it's only in Documentation/snippets/new.
Post by Federico Bruni
Also
grep -r "compressFullBarRests" * | wc -l
gives a count of 38 (of which 14 are *.po files) so we might as well
change it for those files too right?
In which case a tracker would be best.
Let me know.
.po files should not be changed, as they are updated from a single pot
file: Documentation/po/lilypond-doc.pot, which does not contain
compressFullBarRests. So .po files are not up-to-date with the pot file.
But this file has not been updated for years and I can't remember to
which extent it's actually used by the doc build system. I would ignore
it.

German and japanese translation are out-of-date, but translators are in
charge of keeping it up-to-date.

IMO we should open a new issue only for the snippet.

Loading...